Skip to content

Don't continue parsing expressions after ternary operators. #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

zherczeg
Copy link
Member

@zherczeg zherczeg commented Jun 4, 2020

Further benefits: new code requires less checks.

Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Further benefits: new code requires less checks.

Fixes jerryscript-project#3841
Fixes jerryscript-project#3842

JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg [email protected]
Copy link
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit e6ebc2b into jerryscript-project:master Jun 4, 2020
@zherczeg zherczeg deleted the ternary_rework branch June 4, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion context_p->token.type != LEXER_RIGHT_PAREN Assertion PARSER_ARGS_EQ (opcode, 0)
3 participants